Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Clearer error messaging and documented user-data dir (3.0.1) #1542

Merged
merged 37 commits into from
Apr 28, 2024

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Apr 21, 2024

✨ Feature 📕 Docs Large Lissy93 /FEAT/3.0.1-improvements → Lissy93/dashy Commits: 37 | Files Changed: 41 | Additions: 490 Powered by Pull Request Badge

Category:
Better troubleshooting. More secure auth. Refactors. Bug fixes

Overview

Issue Number see above

New Vars N/A

Screenshot (if applicable)

Before After
image image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 3fb87fa
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/662ebf47f6478a0008f6a61e
😎 Deploy Preview https://deploy-preview-1542--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Lissy93 Lissy93 added ✨ New Feature [PR] Contains implementation of a new feature 📕 Docs [PR] Contains improvments or additions to documentation labels Apr 21, 2024
@liss-bot
Copy link
Collaborator

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@sentry-internal/feedback UPDATED 7.110.0 7.111.0
@sentry-internal/replay-canvas UPDATED 7.110.0 7.111.0
@sentry-internal/tracing UPDATED 7.110.0 7.111.0
@sentry/browser UPDATED 7.110.0 7.111.0
@sentry/core UPDATED 7.110.0 7.111.0
@sentry/replay UPDATED 7.110.0 7.111.0
@sentry/tracing UPDATED 7.110.0 7.111.0
@sentry/types UPDATED 7.110.0 7.111.0
@sentry/utils UPDATED 7.110.0 7.111.0
@sentry/vue UPDATED 7.110.0 7.111.0
@types/eslint UPDATED 8.56.9 8.56.10
@types/qs UPDATED 6.9.14 6.9.15
@vue/compiler-core UPDATED 3.4.21 3.4.23
@vue/compiler-dom UPDATED 3.4.21 3.4.23
@vue/compiler-sfc UPDATED 3.4.21 3.4.23
@vue/compiler-ssr UPDATED 3.4.21 3.4.23
@vue/shared UPDATED 3.4.21 3.4.23
basic-auth ADDED - 2.0.1
caniuse-lite UPDATED 1.0.30001609 1.0.30001612
core-js UPDATED 3.36.1 3.37.0
core-js-compat UPDATED 3.36.1 3.37.0
electron-to-chromium UPDATED 1.4.736 1.4.745
express-basic-auth ADDED - 1.2.1
magic-string UPDATED 0.30.9 0.30.10

Copy link
Owner Author

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ready for merge

Copy link
Collaborator

@CrazyWolf13 CrazyWolf13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks awesome,
✨ And good to me !
🎉

@liss-bot

This comment was marked as outdated.

@CrazyWolf13
Copy link
Collaborator

@Lissy93 While you are at it, could you increase the time limit before possible error screen pops up on initial build ?

Noticed, that on lower end devices that screen will pop up, but after waiting like 30-60sec more it works just fine after reloading the page.

@Lissy93
Copy link
Owner Author

Lissy93 commented Apr 28, 2024

While you are at it, could you increase the time limit before possible error screen pops up on initial build ?

Yes! Will do now :)

But since the Dockerfile now doesn't build the app in the run stage, this screen should be seen much less often.

@liss-bot

This comment was marked as outdated.

@liss-bot

This comment was marked as duplicate.

@liss-bot

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕 Docs [PR] Contains improvments or additions to documentation ✨ New Feature [PR] Contains implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants