-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues identified during testing #31
Conversation
dd65078
to
bac3a2d
Compare
bac3a2d
to
825a0fe
Compare
0b938dc
to
f31328d
Compare
f31328d
to
81e3e31
Compare
…red before starting server
00b1aab
to
30b9e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small suggestion.
Also I have another suggestion, we can remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What was the problem?
This PR resolves #30
How was it solved?
%w
with%v
)How was it tested?
Local