Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Unable to fetch top token balances for certain accounts #2065

Conversation

sameersubudhi
Copy link
Contributor

What was the problem?

This PR resolves #2064

How was it solved?

  • Fix the join query for top balance retrieval
  • Fix genesis account indexing count logic

How was it tested?

Locally

@sameersubudhi sameersubudhi self-assigned this May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.89%. Comparing base (8f88ea7) to head (2b526ab).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2065   +/-   ##
============================================
  Coverage        67.89%   67.89%           
============================================
  Files              303      303           
  Lines             5703     5703           
  Branches          1081     1081           
============================================
  Hits              3872     3872           
  Misses            1831     1831           
Files Coverage Δ
...r/shared/dataService/business/token/topBalances.js 100.00% <ø> (ø)
...chain-indexer/tests/unit/shared/constants/token.js 100.00% <ø> (ø)

Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 60e7328 into development May 15, 2024
10 checks passed
@sameersubudhi sameersubudhi deleted the 2064-unable-to-fetch-top-token-balances-for-certain-accounts branch May 15, 2024 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fetch top token balances for certain accounts
2 participants