Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Pending Transactions appear in transactions?blockID queries #2015

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Jan 24, 2024

What was the problem?

This PR resolves #2013

How was it solved?

  • Return empty pending transactions list when queried by blockID, height or timestamp

How was it tested?

Local

@nagdahimanshu nagdahimanshu self-assigned this Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1a8da32) 68.07% compared to head (3e61acc) 68.02%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2015      +/-   ##
===============================================
- Coverage        68.07%   68.02%   -0.05%     
===============================================
  Files              299      299              
  Lines             5344     5336       -8     
  Branches           977      975       -2     
===============================================
- Hits              3638     3630       -8     
  Misses            1706     1706              
Files Coverage Δ
...shared/dataService/business/pendingTransactions.js 90.36% <80.00%> (-0.85%) ⬇️

@nagdahimanshu nagdahimanshu marked this pull request as ready for review January 24, 2024 16:29
@nagdahimanshu nagdahimanshu force-pushed the 2013-fix-pending-transactions-query branch from 49e37bf to 3e61acc Compare January 24, 2024 17:03
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 559d266 into development Jan 25, 2024
9 of 10 checks passed
@sameersubudhi sameersubudhi deleted the 2013-fix-pending-transactions-query branch January 25, 2024 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending Transactions appear in transactions?blockID queries
2 participants