Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add handling for txpool_newTransaction event #2009

Merged

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Jan 5, 2024

What was the problem?

This PR resolves #2006

How was it solved?

  • Add handling for txpool_newTransaction event
  • Emit event transaction.new in case of txpool_newTransaction event as well
  • Update pending transaction list when txpool_newTransaction event is received

How was it tested?

Local + Server

@nagdahimanshu nagdahimanshu self-assigned this Jan 5, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a4248c1) 68.07% compared to head (aaba729) 68.07%.

❗ Current head aaba729 differs from pull request most recent head 958d3c1. Consider uploading reports for the commit 958d3c1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2009      +/-   ##
===============================================
- Coverage        68.07%   68.07%   -0.01%     
===============================================
  Files              299      299              
  Lines             5338     5344       +6     
  Branches           977      977              
===============================================
+ Hits              3634     3638       +4     
- Misses            1704     1706       +2     
Files Coverage Δ
...chain-indexer/shared/dataService/business/index.js 100.00% <100.00%> (ø)
...ces/blockchain-indexer/shared/dataService/index.js 100.00% <ø> (ø)
...shared/dataService/business/pendingTransactions.js 91.20% <91.30%> (-1.74%) ⬇️

@nagdahimanshu nagdahimanshu marked this pull request as ready for review January 8, 2024 14:40
@nagdahimanshu nagdahimanshu force-pushed the 2006-add-handling-for-txpool-newtransaction-event branch from aaba729 to 958d3c1 Compare January 8, 2024 15:07
@sameersubudhi sameersubudhi merged commit b83e921 into development Jan 8, 2024
13 of 14 checks passed
@sameersubudhi sameersubudhi deleted the 2006-add-handling-for-txpool-newtransaction-event branch January 8, 2024 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add handling for txpool_newTransaction event
2 participants