Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Investigate lisk-core crash due to memory leak #1994

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Investigate lisk-core crash due to memory leak #1994

merged 10 commits into from
Dec 20, 2023

Conversation

priojeetpriyom
Copy link
Contributor

@priojeetpriyom priojeetpriyom commented Dec 18, 2023 •
edited
Loading

What was the problem?

This PR resolves #1993

How was it solved?

  • Decouple client instantiation from client fetch logic using a cached client pool
  • Periodically check cached clients for liveliness and replace dead clients
  • Remove unused config values
  • Add pos_getExpectedSharedRewards default value of INVOKE_ALLOWED_METHODS

How was it tested?

  • Local and cloud droplets

@priojeetpriyom priojeetpriyom self-assigned this Dec 18, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c583a20) 68.14% compared to head (4c708ce) 68.13%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1994      +/-   ##
===============================================
- Coverage        68.14%   68.13%   -0.02%     
===============================================
  Files              299      299              
  Lines             5324     5322       -2     
  Branches           975      973       -2     
===============================================
- Hits              3628     3626       -2     
  Misses            1696     1696
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <ø> (ø)
services/blockchain-indexer/config.js 98.27% <ø> (ø)

@priojeetpriyom priojeetpriyom changed the title 1993 investigate lisk core crash due to memory leak Investigate lisk-core crash due to memory leak Dec 18, 2023
@priojeetpriyom priojeetpriyom force-pushed the 1993-investigate-lisk-core-crash-due-to-memory-leak branch from 7a68a78 to 4582b39 Compare December 19, 2023 13:27
@priojeetpriyom priojeetpriyom marked this pull request as ready for review December 19, 2023 13:33
nagdahimanshu
nagdahimanshu approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nagdahimanshu nagdahimanshu merged commit 16f90e1 into development Dec 20, 2023
10 checks passed
@nagdahimanshu nagdahimanshu deleted the 1993-investigate-lisk-core-crash-due-to-memory-leak branch December 20, 2023 15:08
@sameersubudhi sameersubudhi mentioned this pull request Jan 4, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nagdahimanshu nagdahimanshu nagdahimanshu approved these changes

@vardan10 vardan10 vardan10 approved these changes

Assignees

@priojeetpriyom priojeetpriyom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate lisk-core crash due to memory leak
3 participants
@priojeetpriyom @vardan10 @nagdahimanshu