Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Missing error handling in coordinator #1983

Merged

Conversation

priojeetpriyom
Copy link
Contributor

@priojeetpriyom priojeetpriyom commented Dec 7, 2023

What was the problem?

This PR resolves #1979

How was it solved?

  • Cached all pos validators on new/delete block events and at init.
  • Update default value for ENDPOINT_INVOKE_MAX_RETRIES

How was it tested?

  • Local

@priojeetpriyom priojeetpriyom self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1983 (c8e25a3) into development (a1ef426) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1983   +/-   ##
============================================
  Coverage        68.11%   68.11%           
============================================
  Files              299      299           
  Lines             5319     5319           
  Branches           975      975           
============================================
  Hits              3623     3623           
  Misses            1696     1696           
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <100.00%> (ø)

@priojeetpriyom priojeetpriyom marked this pull request as ready for review December 7, 2023 16:05
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sameersubudhi sameersubudhi merged commit 587106c into development Dec 7, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1979-missing-error-handling-in-coordinator branch December 7, 2023 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing error handling in coordinator
3 participants