Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Conversation

vardan10
Copy link
Contributor

@vardan10 vardan10 commented Dec 7, 2023

What was the problem?

This PR resolves #1978

How was it solved?

  • Updated node liveliness check mechanism

How was it tested?

Local

@vardan10 vardan10 self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1981 (b617395) into development (23b2767) will increase coverage by 0.00%.
Report is 15 commits behind head on development.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1981   +/-   ##
============================================
  Coverage        68.10%   68.11%           
============================================
  Files              299      299           
  Lines             5318     5319    +1     
  Branches           975      975           
============================================
+ Hits              3622     3623    +1     
  Misses            1696     1696           
Files Coverage Δ
services/blockchain-connector/config.js 100.00% <ø> (ø)
...ervices/blockchain-connector/shared/geolocation.js 44.68% <0.00%> (ø)
...es/blockchain-indexer/shared/dataService/blocks.js 28.35% <0.00%> (ø)
...ices/blockchain-connector/shared/utils/download.js 36.66% <0.00%> (ø)

... and 1 file with indirect coverage changes

@vardan10 vardan10 marked this pull request as ready for review December 7, 2023 14:16
@vardan10 vardan10 force-pushed the 1978-Connector-creates-too-many-ws-connections-with-the-node-which-stresses-out-the-node branch from b9efc4b to 1a95c33 Compare December 7, 2023 15:15
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@priojeetpriyom priojeetpriyom merged commit 8a5ac48 into development Dec 11, 2023
9 of 10 checks passed
@priojeetpriyom priojeetpriyom deleted the 1978-Connector-creates-too-many-ws-connections-with-the-node-which-stresses-out-the-node branch December 11, 2023 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector creates too many ws connections with the node which stresses out the node
3 participants