Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Transaction fees estimate failing #1936

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Nov 22, 2023

What was the problem?

This PR resolves #1935

How was it solved?

  • Fix calcDynamicFeeEstimates to handle estimatePerByte values to be decimals
  • Update tests accordingly
  • Update instantiateClient and resetApiClient signal triggering
  • Fix the clearInterval invocation within waitForIt

How was it tested?

  • cd services/blockchain-indexer
  • yarn test transactionsEstimateFees

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #1936 (9bfa4fc) into release/0.7.0 (06ce21f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.7.0    #1936   +/-   ##
==============================================
  Coverage          67.78%   67.78%           
==============================================
  Files                299      299           
  Lines               5284     5284           
  Branches             963      963           
==============================================
  Hits                3582     3582           
  Misses              1702     1702           
Files Coverage Δ
...d/dataService/business/transactionsEstimateFees.js 93.44% <ø> (ø)

@sameersubudhi sameersubudhi force-pushed the 1935-transaction-fees-estimate-failing branch from 3b1780d to e573b18 Compare November 22, 2023 09:17
@priojeetpriyom priojeetpriyom changed the title Fransaction fees estimate failing Transaction fees estimate failing Nov 22, 2023
@sameersubudhi sameersubudhi force-pushed the 1935-transaction-fees-estimate-failing branch 2 times, most recently from f0153e9 to 43a221a Compare November 22, 2023 13:00
@sameersubudhi sameersubudhi force-pushed the 1935-transaction-fees-estimate-failing branch 2 times, most recently from 3eaf856 to 539fd02 Compare November 22, 2023 13:39
@sameersubudhi sameersubudhi force-pushed the 1935-transaction-fees-estimate-failing branch from 21d5ed2 to 9bfa4fc Compare November 22, 2023 14:40
@sameersubudhi sameersubudhi merged commit e179feb into release/0.7.0 Nov 22, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1935-transaction-fees-estimate-failing branch November 22, 2023 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants