Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Incorrect information in new.block event payload #1932

Merged

Conversation

priojeetpriyom
Copy link
Contributor

@priojeetpriyom priojeetpriyom commented Nov 20, 2023

What was the problem?

This PR resolves #1930

How was it solved?

  • Fetch transactions by blockID before formatting to generate numberOfTransactions
  • Use processed transactions as transactions payload instead of querying node

How was it tested?

  • Local

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #1932 (6b8d2c3) into release/0.7.0 (e179feb) will decrease coverage by 0.08%.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.7.0    #1932      +/-   ##
=================================================
- Coverage          67.78%   67.71%   -0.08%     
=================================================
  Files                299      299              
  Lines               5284     5290       +6     
  Branches             963      968       +5     
=================================================
  Hits                3582     3582              
- Misses              1702     1708       +6     
Files Coverage Δ
...es/blockchain-indexer/shared/dataService/blocks.js 28.78% <25.00%> (-0.90%) ⬇️
...hain-indexer/shared/dataService/business/blocks.js 17.79% <16.66%> (-0.45%) ⬇️

@vardan10 vardan10 merged commit 4735a6d into release/0.7.0 Nov 22, 2023
6 of 8 checks passed
@vardan10 vardan10 deleted the 1930-incorrect-information-in-new-block-event-payload branch November 22, 2023 16:38
@vardan10 vardan10 linked an issue Nov 22, 2023 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect information in new.block event payload
3 participants