Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fee error while sending a transaction from sidechain to mainchain #1928

Conversation

priojeetpriyom
Copy link
Contributor

@priojeetpriyom priojeetpriyom commented Nov 15, 2023

What was the problem?

This PR resolves #1925

How was it solved?

  • Check sender address exists in blockchain for transaction tokenID, fee tokenID and message fee tokenID
  • Handle case when ccm success event is not present from transaction dry run

How was it tested?

  • Local against testnet

@priojeetpriyom priojeetpriyom self-assigned this Nov 15, 2023
@sameersubudhi sameersubudhi force-pushed the 1925-fee-error-while-sending-a-transaction-from-sidechain-to-mainchain branch from 0e0c20b to edc7fcb Compare November 17, 2023 15:00
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #1928 (08c7cb6) into release/0.7.0 (5284ad8) will decrease coverage by 0.32%.
Report is 7 commits behind head on release/0.7.0.
The diff coverage is 70.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.7.0    #1928      +/-   ##
=================================================
- Coverage          67.01%   66.69%   -0.32%     
=================================================
  Files                298      298              
  Lines               5254     5276      +22     
  Branches             954      960       +6     
=================================================
- Hits                3521     3519       -2     
- Misses              1733     1757      +24     
Files Coverage Δ
services/blockchain-indexer/shared/constants.js 53.57% <100.00%> (+0.55%) ⬆️
...s/unit/shared/constants/transactionEstimateFees.js 100.00% <100.00%> (ø)
...d/dataService/business/transactionsEstimateFees.js 88.52% <64.00%> (-5.31%) ⬇️

... and 2 files with indirect coverage changes

@sameersubudhi sameersubudhi force-pushed the 1925-fee-error-while-sending-a-transaction-from-sidechain-to-mainchain branch from 971c33d to 0c17766 Compare November 17, 2023 17:00
@sameersubudhi sameersubudhi force-pushed the 1925-fee-error-while-sending-a-transaction-from-sidechain-to-mainchain branch from 0c17766 to 08c7cb6 Compare November 17, 2023 17:25
@sameersubudhi sameersubudhi self-assigned this Nov 17, 2023
@sameersubudhi sameersubudhi merged commit 4df7bb4 into release/0.7.0 Nov 17, 2023
@sameersubudhi sameersubudhi deleted the 1925-fee-error-while-sending-a-transaction-from-sidechain-to-mainchain branch November 17, 2023 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants