Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Lisk Service does not work against the migrated mainnet #1913

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Nov 6, 2023

What was the problem?

This PR resolves #1912

How was it

  • Add limit to 1000 when requesting genesis assets from connector
  • Initialise constants in connector at start
  • Improve logging

How was it tested?

local + Server against mainnet

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1913 (6e5520f) into release/0.7.0 (2a4ad06) will not change coverage.
Report is 7 commits behind head on release/0.7.0.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.7.0    #1913   +/-   ##
==============================================
  Coverage          66.62%   66.62%           
==============================================
  Files                298      298           
  Lines               5250     5250           
  Branches             949      949           
==============================================
  Hits                3498     3498           
  Misses              1752     1752           
Files Coverage Δ
...kchain-indexer/shared/dataService/knownAccounts.js 100.00% <100.00%> (ø)

@nagdahimanshu nagdahimanshu marked this pull request as ready for review November 7, 2023 09:40
@nagdahimanshu nagdahimanshu changed the title Lisk Service does work against the migrated mainnet Lisk Service does not work against the migrated mainnet Nov 7, 2023
@sameersubudhi sameersubudhi merged commit 6cfba0b into release/0.7.0 Nov 8, 2023
@sameersubudhi sameersubudhi deleted the 1912-lisk-service-does-work-against-the-migrated-mainnet branch November 8, 2023 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants