Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Incorrect validators rank #1908

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

nagdahimanshu
Copy link
Contributor

@nagdahimanshu nagdahimanshu commented Oct 31, 2023

What was the problem?

This PR resolves #1876

How was it solved?

  • Fix validators sorting logic in case of same validator weight (reverse lexicographic order)
  • Update test case
  • Validate validators rank job should not detect incorrect rank

How was it tested?

Locally against testnet

@nagdahimanshu nagdahimanshu self-assigned this Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1908 (79386df) into release/0.7.0 (8b1c9a3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.7.0    #1908   +/-   ##
==============================================
  Coverage          66.59%   66.59%           
==============================================
  Files                298      298           
  Lines               5245     5245           
  Branches             945      945           
==============================================
  Hits                3493     3493           
  Misses              1752     1752           
Files Coverage Δ
...chain-indexer/shared/dataService/pos/validators.js 24.04% <100.00%> (ø)

@nagdahimanshu nagdahimanshu marked this pull request as ready for review October 31, 2023 14:15
@sameersubudhi sameersubudhi merged commit 8a5104d into release/0.7.0 Oct 31, 2023
@sameersubudhi sameersubudhi deleted the 1876-incorrect-validators-rank branch October 31, 2023 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants