Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Indexing issues against the testnet #1899

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Oct 26, 2023

What was the problem?

This PR resolves #1898

How was it solved?

  • Update getTransactionExecutionStatus to check topics both with and without the transaction topic prefixes
  • Remove betanet support from app-registry
  • Add null check to standardizeCurrencyConversionRates to prevent from crashing

How was it tested?

  • Ran the branch against the testnet
  • Ran it against a devnet node and posted all kinds of transactions with yarn test:stress script

@sameersubudhi sameersubudhi self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1899 (f019cf3) into release/0.7.0 (8d4a2f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.7.0    #1899   +/-   ##
==============================================
  Coverage          66.62%   66.63%           
==============================================
  Files                298      298           
  Lines               5229     5230    +1     
  Branches             941      942    +1     
==============================================
+ Hits                3484     3485    +1     
  Misses              1745     1745           
Files Coverage Δ
services/blockchain-app-registry/config.js 100.00% <100.00%> (ø)
...es/blockchain-indexer/shared/utils/transactions.js 100.00% <100.00%> (ø)

@sameersubudhi sameersubudhi merged commit 04d0de9 into release/0.7.0 Oct 26, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1898-indexing-issues-against-the-testnet branch October 26, 2023 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants