This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Improve handling of deleted blocks #1896
Merged
sameersubudhi
merged 27 commits into
release/0.7.0
from
1191-improve-handling-of-deleted-blocks
Nov 10, 2023
Merged
Improve handling of deleted blocks #1896
sameersubudhi
merged 27 commits into
release/0.7.0
from
1191-improve-handling-of-deleted-blocks
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/0.7.0 #1896 +/- ##
=================================================
+ Coverage 66.62% 67.01% +0.38%
=================================================
Files 298 298
Lines 5250 5254 +4
Branches 949 954 +5
=================================================
+ Hits 3498 3521 +23
+ Misses 1752 1733 -19
|
services/blockchain-indexer/shared/dataService/business/blocks.js
Outdated
Show resolved
Hide resolved
sameersubudhi
suggested changes
Nov 7, 2023
services/blockchain-indexer/shared/dataService/business/blocks.js
Outdated
Show resolved
Hide resolved
priojeetpriyom
force-pushed
the
1191-improve-handling-of-deleted-blocks
branch
from
November 9, 2023 13:46
84a0fa1
to
ee1d26a
Compare
sameersubudhi
force-pushed
the
1191-improve-handling-of-deleted-blocks
branch
from
November 9, 2023 15:37
04cf0a6
to
afd8f40
Compare
sameersubudhi
force-pushed
the
1191-improve-handling-of-deleted-blocks
branch
from
November 9, 2023 15:53
afd8f40
to
c2d0fdf
Compare
sameersubudhi
force-pushed
the
1191-improve-handling-of-deleted-blocks
branch
from
November 10, 2023 09:44
1d8594f
to
004b8c6
Compare
Co-authored-by: Himanshu Nagda <[email protected]>
nagdahimanshu
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
nagdahimanshu
force-pushed
the
1191-improve-handling-of-deleted-blocks
branch
from
November 10, 2023 11:44
061fffe
to
6b8dc0e
Compare
nagdahimanshu
force-pushed
the
1191-improve-handling-of-deleted-blocks
branch
from
November 10, 2023 11:48
6b8dc0e
to
19b8749
Compare
sameersubudhi
approved these changes
Nov 10, 2023
This was referenced Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #1191
How was it solved?
How was it tested?
priojeet-testnet-[1-4]-improve-handling-of-deleted-blocks