Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Multiple connections to SQLite DB #1879

Merged
merged 12 commits into from
Oct 25, 2023

Conversation

vardan10
Copy link
Contributor

@vardan10 vardan10 commented Oct 19, 2023

What was the problem?

This PR resolves #1866

How was it solved?

  • Updated sqlite to have 1 connection per db

How was it tested?

Deployed against testnet and indexed more than 15k blocks without any error.

@vardan10 vardan10 force-pushed the 1866-multiple-connections-to-SQLite-DB branch from a3091d2 to 9e278b6 Compare October 19, 2023 05:30
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #1879 (b5d0c8f) into release/0.7.0 (3d303f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.7.0    #1879   +/-   ##
==============================================
  Coverage          66.62%   66.62%           
==============================================
  Files                298      298           
  Lines               5229     5229           
  Branches             941      941           
==============================================
  Hits                3484     3484           
  Misses              1745     1745           

@vardan10 vardan10 linked an issue Oct 20, 2023 that may be closed by this pull request
@vardan10 vardan10 marked this pull request as ready for review October 25, 2023 10:34
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vardan10 vardan10 force-pushed the 1866-multiple-connections-to-SQLite-DB branch from 993489b to d099e69 Compare October 25, 2023 12:51
@sameersubudhi sameersubudhi merged commit 96d3e27 into release/0.7.0 Oct 25, 2023
8 checks passed
@sameersubudhi sameersubudhi deleted the 1866-multiple-connections-to-SQLite-DB branch October 25, 2023 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple connections to SQLite DB
3 participants