This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Inconsistent Validator Information Across Multiple Service Instances #1692
Merged
sameersubudhi
merged 103 commits into
release/0.7.0
from
1673-fix-inconsistent-validator-information
Oct 20, 2023
Merged
Inconsistent Validator Information Across Multiple Service Instances #1692
sameersubudhi
merged 103 commits into
release/0.7.0
from
1673-fix-inconsistent-validator-information
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip missing blocks scheduling job in some cases Add log messages
…into 1673-fix-inconsistent-validator-information
Codecov Report
@@ Coverage Diff @@
## release/0.7.0 #1692 +/- ##
=================================================
+ Coverage 66.82% 66.84% +0.02%
=================================================
Files 298 298
Lines 5112 5128 +16
Branches 922 925 +3
=================================================
+ Hits 3416 3428 +12
- Misses 1696 1700 +4
|
…into 1673-fix-inconsistent-validator-information
Update node constants in cache on every new block
…into 1673-fix-inconsistent-validator-information
sameersubudhi
force-pushed
the
1673-fix-inconsistent-validator-information
branch
9 times, most recently
from
June 23, 2023 13:07
fc567b7
to
5722156
Compare
sameersubudhi
force-pushed
the
1673-fix-inconsistent-validator-information
branch
2 times, most recently
from
June 23, 2023 14:57
7bb5e62
to
e7619be
Compare
priojeetpriyom
approved these changes
Oct 20, 2023
Looks good to me 👍 |
sameersubudhi
approved these changes
Oct 20, 2023
This was referenced Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #1673
How was it solved?
How was it tested?
rc6-validator-incosistency-1-devnet-node-blocktime-4sec (seed),
rc6-validator-incosistency-2-devnet-node-blocktime-4sec (peer),
rc6-validator-incosistency-3-devnet-node-blocktime-4sec (peer)