Major update of PoS unit tests (#9193)

* Improve Stake command unit tests * Fix test case when downstake allows more upstake capacity * Fix stake test not initializing Staker Store data * Fix and rename `RegisterValidatorCommand` tests and add `isUsername()` tests * Fix punished accounts unlock scenario * Fix format issue
LiskArchive · Jan 8, 2024 · 2062593 · 2062593
1 parent 7fde5ff
commit 2062593
Show file tree

Hide file tree

Showing 6 changed files with 442 additions and 355 deletions.
diff --git a/framework/src/modules/pos/commands/stake.ts b/framework/src/modules/pos/commands/stake.ts
@@ -97,7 +97,7 @@ export class StakeCommand extends BaseCommand {
 				return {
 					status: VerifyStatus.FAIL,
 					error: new ValidationError(
-						'Amount should be multiple of 10 * 10^8.',
+						`Amount should be multiple of ${this._baseStakeAmount}.`,
 						stake.amount.toString(),
 					),
 				};

diff --git a/framework/test/unit/modules/pos/commands/claim_rewards.spec.ts b/framework/test/unit/modules/pos/commands/claim_rewards.spec.ts
@@ -26,7 +26,7 @@ import { PrefixedStateReadWriter } from '../../../../../src/state_machine/prefix
 import { createFakeBlockHeader, InMemoryPrefixedStateDB } from '../../../../../src/testing';
 import { createStoreGetter } from '../../../../../src/testing/utils';
 
-describe('Change Commission command', () => {
+describe('Claim Rewards command', () => {
 	const pos = new PoSModule();
 	const publicKey = utils.getRandomBytes(32);
 	const senderAddress = address.getAddressFromPublicKey(publicKey);

diff --git a/framework/test/unit/modules/pos/commands/register_validator.spec.ts b/framework/test/unit/modules/pos/commands/register_validator.spec.ts
@@ -37,6 +37,7 @@ import {
 	VALIDATOR_REGISTRATION_FEE,
 } from '../../../../../src/modules/pos/constants';
 import { ValidatorRegisteredEvent } from '../../../../../src/modules/pos/events/validator_registered';
+import { liskToBeddows } from '../../../../utils/assets';
 
 describe('Validator registration command', () => {
 	const pos = new Modules.PoS.PoSModule();
@@ -53,7 +54,6 @@ describe('Validator registration command', () => {
 		generatorKey: utils.getRandomBytes(32),
 		blsKey: utils.getRandomBytes(48),
 		proofOfPossession: utils.getRandomBytes(96),
-		validatorRegistrationFee: VALIDATOR_REGISTRATION_FEE,
 	};
 	const defaultValidatorInfo = {
 		name: transactionParams.name,
@@ -77,7 +77,7 @@ describe('Validator registration command', () => {
 		command: 'registerValidator',
 		senderPublicKey: publicKey,
 		nonce: BigInt(0),
-		fee: BigInt(1000000000),
+		fee: liskToBeddows(20),
 		params: encodedTransactionParams,
 		signatures: [publicKey],
 	});
@@ -206,7 +206,7 @@ describe('Validator registration command', () => {
 				command: 'registerValidator',
 				senderPublicKey: publicKey,
 				nonce: BigInt(0),
-				fee: BigInt(100000000),
+				fee: liskToBeddows(1),
 				params: invalidParams,
 				signatures: [publicKey],
 			});