Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includeHeaderValues option #23

Closed
wants to merge 3 commits into from

Conversation

aneilbaboo
Copy link

This PR provides the ability to include header values when generating the filename hash. This addresses #21.

Now you can do:

var sinon = require('sinon');
sinon.configure({ includeHeaderValues: true });

The generated hash will be sensitive to header values, and if a headerWhitelist is set only values from those headers will be used. Note that it is redundant to set includeHeaderNames when includeHeaderValues is set.

  • updated the README
  • added tests

Note: To preserve backwards compatibility with existing filenames, I preserved “headerNames”
in the hashparts array instead of renaming it to “headers” as would otherwise make sense.

* updated the README
* added tests

To preserve backwards compatibility with existing filenames, I preserved “headerNames”
in the hashparts array instead of renaming it to “headers” as would otherwise make sense.
@aneilbaboo
Copy link
Author

@salvipriyanka @avik-das @delwyn @deepankgupta - Sorry to spam you all. Who is the right person to get this PR accepted?

@palmerj3
Copy link

@aneilbaboo I also have a crucial PR I need merged... given that this repo appears abandoned what would you think about starting a new project based on a fork of this? Give it a different name so we can publish to NPM. And link to the original, of course, in the README. Thoughts?

@aneilbaboo
Copy link
Author

@palmerj3 Yes, I've been thinking the same thing. It's been a long time and several attempts with no response.

I figured that to make this a living breathing project, we should start with a new name so we can have consistency between npm and github. "Replayer" was available, so I used that.

I created the fork at https://github.com/aneilbaboo/replayer, and made you a contributor. I just made the package available on NPM too, and it uses the same revision number. The only thing necessary should be renaming sepia=>replayer.

I made you a contributor.

@aneilbaboo
Copy link
Author

I'll create an issue announcing the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants