Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the ability to include header values when generating the filename hash. This addresses #21.
Now you can do:
The generated hash will be sensitive to header values, and if a headerWhitelist is set only values from those headers will be used. Note that it is redundant to set includeHeaderNames when includeHeaderValues is set.
Note: To preserve backwards compatibility with existing filenames, I preserved “headerNames”
in the hashparts array instead of renaming it to “headers” as would otherwise make sense.