Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

check parentNode is not null - fixes #296 #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drujensen
Copy link

@drujensen drujensen commented Feb 23, 2018

This change checks that the parentNode is not null before trying to call removeChild on it. This fixes #296 where someone may call endTour but startTour was not called yet.

if (el && el.parentNode)

I also had to update the grunt-rollup npm package to the latest in order to build the project.

@drujensen
Copy link
Author

Any update on this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on endTour(true) -- TypeError: Cannot read property 'removeChild' of null
1 participant