This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Swift 4.2 migration #244
Open
Swift 4.2 migration #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 1, 2018 10:02
Note: `pod lib lint` requires CocoaPods 1.6 for tvOS pod sanity test to pass
|
Are the tests passing locally? Travis is showing errors, but it seems more like its probably just not configured correctly for the 4.2 update. |
Closed
This adds `-disable-concurrent-destination-testing` flag to xcodebuild commands with multiple destinations to disable concurrency issues happening on XCODE 10 target. This also updates Apple TV target to `4k (at 1080)` since normal 1080p version does not seem to have an iOS 11.0 simulator target.
|
Testing on my fork, this fixed the travis issues for me, except for the last step, which was pulling the latest version from cocoapods, which pulled version of code prior to your syntax updates in this PR... and so failed after 10 minutes because of that. |
|
👍 |
|
Hi! Any progress? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
pod lib lintrequires CocoaPods 1.6 for tvOS pod sanity test to pass