-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XMPP Block option #810
base: main
Are you sure you want to change the base?
Conversation
I look forward to this PR |
same! thanks for working on this @nekosheen @papergram |
Thank you for contributing @nekosheen and @papergram! We cannot merge this request at this time. The documentation for the blocks system has not yet been released, which may have led to some confusion. I am working on releasing this documentation as soon as possible, including an example. Given the current situation, I will be handling this addition for now. It would be helpful if one of you could assist with this process. Please note that our block system is still under development, and there may be changes in the future. The primary requirement for a block is that it must be fully self-contained. This means all files should be included within the block folder itself, with no need for database modifications. Here are some of the features we've added to support this:
Currently, we do not support custom file uploads. |
This is a basic example of an XMPP block. If you add this block to an instance running the latest beta, it should show the new block in the block list and be able to save an XMPP button. |
Can this PR be modified with your file content? |
Yes, but the file needs to be improved on. The current state is not production ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use new block format.
Documentation and an example block is now available: https://github.com/LinkStackOrg/linkstack-blocks/wiki |
Is there anyone who can finalize this PR? |
I haven't been able to fully test this block yet. Could someone please confirm that it works as expected? Also, validation needs to be added when saving the link. You can refer to this example. Someone should review the block icons. Once that's done, the block should be ready for production. |
Adds XMPP block option (Issue #805)
Adds XMPP pre-defined block