Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XMPP Block option #810

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add XMPP Block option #810

wants to merge 10 commits into from

Conversation

nekosheen
Copy link

@nekosheen nekosheen commented Aug 18, 2024

Adds XMPP block option (Issue #805)
Adds XMPP pre-defined block

@nekosheen
Copy link
Author

nekosheen commented Aug 18, 2024

add XMPP in pre-defined list as well
image

image

@nekosheen
Copy link
Author

Still struggling with icon
image

@nicfab
Copy link

nicfab commented Sep 5, 2024

I look forward to this PR

@colinstu12
Copy link

I look forward to this PR

same! thanks for working on this @nekosheen @papergram

@nekosheen nekosheen marked this pull request as ready for review September 7, 2024 09:43
@JulianPrieber JulianPrieber self-assigned this Sep 16, 2024
@JulianPrieber
Copy link
Member

Thank you for contributing @nekosheen and @papergram!

We cannot merge this request at this time.

The documentation for the blocks system has not yet been released, which may have led to some confusion. I am working on releasing this documentation as soon as possible, including an example.

Given the current situation, I will be handling this addition for now. It would be helpful if one of you could assist with this process.

Please note that our block system is still under development, and there may be changes in the future.

The primary requirement for a block is that it must be fully self-contained. This means all files should be included within the block folder itself, with no need for database modifications.

Here are some of the features we've added to support this:

  • Dynamic loading of asset files
  • Dynamic loading of asset URL paths
  • Built-in translation support within the block (additional translations for other languages may require updates to their respective translation files)

Currently, we do not support custom file uploads.

@JulianPrieber
Copy link
Member

xmpp.zip

This is a basic example of an XMPP block.

If you add this block to an instance running the latest beta, it should show the new block in the block list and be able to save an XMPP button.

@nicfab
Copy link

nicfab commented Sep 16, 2024

xmpp.zip

This is a basic example of an XMPP block.

If you add this block to an instance running the latest beta, it should show the new block in the block list and be able to save an XMPP button.

Can this PR be modified with your file content?

@JulianPrieber
Copy link
Member

xmpp.zip
This is a basic example of an XMPP block.
If you add this block to an instance running the latest beta, it should show the new block in the block list and be able to save an XMPP button.

Can this PR be modified with your file content?

Yes, but the file needs to be improved on. The current state is not production ready.

Copy link
Member

@JulianPrieber JulianPrieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use new block format.

@JulianPrieber
Copy link
Member

Documentation and an example block is now available:

https://github.com/LinkStackOrg/linkstack-blocks/wiki
https://github.com/LinkStackOrg/example-block

@nicfab
Copy link

nicfab commented Oct 3, 2024

Is there anyone who can finalize this PR?
@nekosheen

@JulianPrieber
Copy link
Member

JulianPrieber commented Oct 7, 2024

I haven't been able to fully test this block yet. Could someone please confirm that it works as expected?

Also, validation needs to be added when saving the link. You can refer to this example.

Someone should review the block icons.

Once that's done, the block should be ready for production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants