DCA ERC20 business logic and signing #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radkomih
changed the title
radkomih
force-pushed
the
feat/dca-business-logic
branch
2 times, most recently
from
28d7f47 to
c56e30b
Compare
radkomih
force-pushed
the
feat/dca-business-logic
branch
from
c56e30b to
2cb6c26
Compare
radkomih
force-pushed
the
feat/dca-business-logic
branch
from
6309cde to
320b656
Compare
radkomih
changed the title
ivalime
reviewed
Feb 13, 2025
| @@ -47,6 +53,24 @@ func (s *Server) SignPluginMessages(c echo.Context) error { | |||
| switch policy.PluginType { | |||
| case "payroll": | |||
| plugin = payroll.NewPayrollPlugin(s.db) | |||
| case "dca": | |||
There was a problem hiding this comment.
This functionality is appearing in a lot of places. I suggest extracting it as a function and re-using it.
There was a problem hiding this comment.
Agree, but I didn't want to change it too much from the upstream version, since upstream changes are still work in progress.
I think it will be easier to merge and then do a refactor.
radkomih
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LimeChain/vultisig-plugins-marketplace#13
There are a couple of TODOs left that will be addressed in upcoming PRs