Implement GRANDPA equivocation #747
Conversation
nistanimirov
requested review from
georg-getz,
hMitov,
Grigorov-Georgi and
Zurcusa
|
|
||
| import java.math.BigInteger; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
I'd add lombok's builder annotation here. https://projectlombok.org/features/Builder
| Runtime runtime = warpSyncState.getRuntime(); | ||
| SignedVote firstSignedVote = votes.get(authorityPublicKey); | ||
|
|
||
| GrandpaEquivocation grandpaEquivocation = new GrandpaEquivocation(); |
|
|
||
| if (votes.containsKey(authorityPublicKey)) { | ||
| equivocations.computeIfAbsent(authorityPublicKey, _ -> new HashSet<>()).add(signedVote); | ||
| Runtime runtime = warpSyncState.getRuntime(); |
There was a problem hiding this comment.
| Runtime runtime = warpSyncState.getRuntime(); | |
| BlockState blockState = stateManager.getBlockState(); | |
| Runtime runtime = bs.getRuntime(bs.getHighestFinalizedHash()); |
| Optional<OpaqueKeyOwnershipProof> opaqueKeyOwnershipProof = runtime.generateGrandpaKeyOwnershipProof(voteMessageSetId, authorityPublicKey.getBytes()); | ||
| opaqueKeyOwnershipProof.ifPresentOrElse( | ||
| key -> runtime.submitReportGrandpaEquivocationUnsignedExtrinsic(grandpaEquivocation, key.getProof()), | ||
| () -> log.warning(String.format( |
There was a problem hiding this comment.
If generateGrandpaKeyOwnershipProof() fails we'll log Failure to report Grandpa vote equivocation for authority: %s. and still return true.
There was a problem hiding this comment.
Yeah because equivocation is still exist we just can't report it
There was a problem hiding this comment.
The outer log in GrandpaMessageHandler is a bit misleading then.
String.format("Reported vote equivocation for round %s, set %s, block hash %s, block number %s", voteMessageSetId, voteMessageSetId, signedMessage.getBlockHash(), signedMessage.getBlockNumber()));
| @@ -91,6 +93,28 @@ public void submitReportEquivocationUnsignedExtrinsic(BlockEquivocationProof blo | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public Optional<OpaqueKeyOwnershipProof> generateGrandpaKeyOwnershipProof(BigInteger authoritySetId, | |||
| byte[] authorityPublicKey) { | |||
There was a problem hiding this comment.
Not sure if this is because of github's UI or the line is not formated.
osrib
force-pushed
the
649-Implement-GRANDPA-equivocation
branch
from
2109db3 to
c07a806
Compare
|
Implement GRANDPA equivocation
Checklist: