feat: make isCompletable field and rename method to checkIfRoundIsCom…

…pletable
LimeChain · Feb 7, 2025 · a76b3e2 · a76b3e2
1 parent ed36e95
commit a76b3e2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/main/java/com/limechain/grandpa/round/GrandpaRound.java b/src/main/java/com/limechain/grandpa/round/GrandpaRound.java
@@ -103,6 +103,12 @@ public class GrandpaRound {
     @Nullable
     private Vote preCommitChoice;
 
+    /**
+     * Is current round completable
+     */
+    @Nullable
+    private boolean isCompletable;
+
     private Map<Hash256, SignedVote> preVotes = new ConcurrentHashMap<>();
     private Map<Hash256, SignedVote> preCommits = new ConcurrentHashMap<>();
     private Vote primaryVote;
@@ -248,7 +254,7 @@ private boolean isFinalizable() {
      *
      * @return if the current round is completable
      */
-    public boolean isCompletable() {
+    public boolean checkIfRoundIsCompletable() {
 
         Map<Vote, Long> votes = getDirectVotes(SubRound.PRE_COMMIT);
         long votesCount = votes.values().stream()
@@ -362,10 +368,11 @@ public BlockHeader findGrandpaGhost() {
             throw new GhostExecutionException("GHOST not found");
         }
 
-        BlockHeader grandpaGhost = selectBlockWithMostVotes(blocks, getPrevBestFinalCandidate());
-        this.grandpaGhost = grandpaGhost;
+        BlockHeader result = selectBlockWithMostVotes(blocks, getPrevBestFinalCandidate());
+        this.grandpaGhost = result;
+        this.isCompletable = checkIfRoundIsCompletable();
 
-        return grandpaGhost;
+        return result;
     }
 
     /**

diff --git a/src/main/java/com/limechain/grandpa/round/PreCommitStage.java b/src/main/java/com/limechain/grandpa/round/PreCommitStage.java
@@ -17,6 +17,7 @@ public void start(GrandpaRound round) {
 
         if (round.isCompletable()) {
             end(round);
+            return;
         }
 
         long timeElapsed = System.currentTimeMillis() - round.getStartTime().toEpochMilli();
@@ -33,10 +34,10 @@ public void start(GrandpaRound round) {
     public void end(GrandpaRound round) {
         log.fine(String.format("Round %d ended pre-commit stage.", round.getRoundNumber()));
 
-        if (!round.getOnStageTimerHandler().isShutdown()) {
+        if (round.getOnStageTimerHandler() != null && !round.getOnStageTimerHandler().isShutdown()) {
             round.getOnStageTimerHandler().shutdown();
+            round.setOnStageTimerHandler(null);
         }
-        round.setOnStageTimerHandler(null);
 
         try {
 
@@ -47,7 +48,7 @@ public void end(GrandpaRound round) {
             log.fine(String.format("Round %d ended start stage.", round.getRoundNumber()));
 
         } catch (GrandpaGenericException e) {
-            log.fine(String.format("Round %d could not end now: %s", round.getRoundNumber(), e.getMessage()));
+            log.fine(String.format("Round %d cannot end now: %s", round.getRoundNumber(), e.getMessage()));
         }
     }
 }