Bug Fix - Type error when evaluating metric depth on Kitti #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also happens when running evaluate or depth_to_pointcloud more generally. Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the type error encountered when evaluating the fine-tuned Depth-Anything model on the Kitti dataset , a similar issue with ZoeDepth was reported here - #2113.
The error had two proposed solutions:
I opted for the second solution, modifying the height and width manually. This decision was made to avoid potential compatibility issues with future versions of xFormers, which may require a more recent version of torch. Downgrading torch, while a viable short-term fix, could lead to more significant maintenance challenges down the line.