Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory calculation #215

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

laisspportugal
Copy link
Collaborator

@laisspportugal laisspportugal commented Oct 11, 2024

Description

This PR comes from a spike where we were trying to understand and fix the memory estimation. When reading one of the articles that was used for creating the memory estimation we realized that the calculation was wrong.

The actual formula is:
16+5 * 8+ round_up_to_2^n( (number of properties +2)* 1.5) ) * 3 * 8
instead of
16+5 * 8+ round_up_to_2^n( (number of properties +2)* 1.5) ) * 3 * 4

It could cause misscalculation and non efficient memory estimation

Checklist

  • The web version was tested and it is running ok
  • The desktop version was tested and it is running ok
  • This change is covered by unit tests

Resources

@laisspportugal laisspportugal changed the title [FIX] Memory calculation Memory calculation Oct 11, 2024
@laisspportugal laisspportugal added the bug Something isn't working label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant