Adding combined person content and person saved tables.

[dessalines]

Context #2444

Must come after #5231

Notes:

• I've removed the content fetch from GetPersonDetails, into its own paged API action: ListPersonContent. Seemed strange to get a person's details, moderated communities, and then a paged content fetch.
• I've removed the saved_only option from post and comment views, and created a dedicate API action (ListPersonSaved) to fetch combined saved content (posts and comments).
  • We've decided on removing duplicated individual type fetches where the combined routes are preferred, and there was a lot of unecessary complication with published order (IE when the item was saved, not when it was created), that I was able to remove.

[dessalines]

@dullbananas the tests are passing, but I couldn't figure out a way to do this using your procedure method, so I used the more verbose AFTER INSERT OR DELETE OR UPDATE OF saved ON post_actions to account for all the changes to the X_actions row.

[dullbananas]

this should work

CREATE PROCEDURE r.create_person_saved_combined_trigger (table_name text)
LANGUAGE plpgsql
AS $a$
BEGIN
    EXECUTE replace($b$ CREATE FUNCTION r.person_saved_combined_change_values_thing ( )
            RETURNS TRIGGER
            LANGUAGE plpgsql
            AS $$
            BEGIN
                IF (TG_OP = 'DELETE') THEN
        DELETE FROM person_saved_combined AS p
        WHERE p.person_id = OLD.person_id
            AND p.thing_id = OLD.thing_id;
    ELSIF (TG_OP = 'INSERT') THEN
        IF NEW.saved IS NOT NULL THEN
            INSERT INTO person_saved_combined (published, person_id, thing_id)
                VALUES (NEW.saved, NEW.person_id, NEW.thing_id);
        END IF;
    ELSIF (TG_OP = 'UPDATE') THEN
        IF NEW.saved IS NOT NULL THEN
            INSERT INTO person_saved_combined (published, person_id, thing_id)
                VALUES (NEW.saved, NEW.person_id, NEW.thing_id);
            -- If saved gets set as null, delete the row
        ELSE
            DELETE FROM person_saved_combined AS p
            WHERE p.person_id = NEW.person_id
                AND p.thing_id = NEW.thing_id;
        END IF;
    END IF;
    RETURN NULL;
            END $$;
    CREATE TRIGGER person_saved_combined
        AFTER INSERT OR DELETE OR UPDATE OF saved ON thing_actions
        FOR EACH ROW
        EXECUTE FUNCTION r.person_saved_combined_change_values_thing ( );
        $b$,
        'thing',
        table_name);
END;
$a$;

CALL r.create_person_saved_combined_trigger ('post');

CALL r.create_person_saved_combined_trigger ('comment');

also, always returning null is incorrect

[dessalines]

That worked! thx.

[Nutomic]

Then rename this column to make it clear.

[Nutomic]

You should be able to move this logic into helper functions which can be used by all the different types.

[Nutomic]

According to the other PR these shouldnt have derive(TS, Serialize, Deserialize) nor ts(export)

[dessalines]

I'd like to do these one at a time, so I'll wait till my previous PR is merged to address everything and mark this as ready for review.