Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added distinguished check for isMod & isAdmin comment user badges #1833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CBerry22
Copy link

@CBerry22 CBerry22 commented Jul 6, 2023

Description

Added a distinguished check to the isMod and isAdmin UserBadges on comments so they will only appear when speaking as a moderator.

This will fix the comment side of #1828

Screenshots

Before

before undistinguished

After

after undistinguished
after distinguished

@dessalines
Copy link
Member

I spose I'd be okay with this, but I personally think its useful to know which users are moderators and admins, even if they aren't speaking in an official capacity.

@Crashdoom
Copy link

I spose I'd be okay with this, but I personally think its useful to know which users are moderators and admins, even if they aren't speaking in an official capacity.

@dessalines Since the admins are shown on the index of Lemmy (fig.1) and mods are shown on the community index (fig.2.), wouldn't that be sufficient for identifying them? The info is also listed on the user profiles for admin and mods respectively.

image
fig.1

image
fig.2

Personally, it does come down to not wanting to flaunt authority as it does tend to make some users really uncomfortable with interacting, even if you're not speaking in an official capacity.

@Crashdoom
Copy link

Crashdoom commented Jul 6, 2023

Well, actually, because of display names, it's somewhat problematic

Multiple people can have the same display name, what's to stop someone from impersonating a mod?

Valid. Hadn't thought of that. Could add a tag next to the user if they're non-local showing either their full username ([email protected]) or just domain.tld. That'd probably be a good idea irrespective of this change since impersonation like this would be really easy under the current system.

EDIT: To borrow a concept from Mastodon, they always show the username for local users (e.g. @crashdoom) but for any remote users, it's always the username and domain (e.g. @[email protected]). Might be worth something similar, even with display names to avoid that confusion.

@LemmyNet LemmyNet deleted a comment from Kommynct Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants