Adding tablet UI for home #1723

dessalines · 2024-11-20T15:17:06Z

I've added:

A list-detail layout for home only.
Switching from a Scaffold.bottomBar to an adaptive navigation bar.
I've tested the regular phone layout, and it works okay.

Example of tablet UI:

Screen_Recording_20241120_111952_Jerboa.Debug.mp4

Fixes #127

app/build.gradle.kts

dessalines · 2024-11-20T16:26:29Z

app/src/main/java/com/jerboa/MainActivity.kt

@@ -115,708 +118,710 @@ class MainActivity : AppCompatActivity() {
            JerboaTheme(
                appSettings = appSettings,
            ) {
-                val appState = rememberJerboaAppState()
+                Surface(modifier = Modifier.fillMaxSize()) {


Only change here is wrapping everything in this surface: its necessary for the navigation bar scaffold, and is in most of the examples.

app/src/main/java/com/jerboa/Utils.kt

app/src/main/java/com/jerboa/ui/components/common/AppBars.kt

app/src/main/java/com/jerboa/ui/components/common/DrawerItems.kt

dessalines · 2024-11-20T16:31:24Z

app/src/main/java/com/jerboa/ui/components/home/HomePane.kt

 import it.vercruysse.lemmyapi.datatypes.PostView
 import it.vercruysse.lemmyapi.datatypes.SavePost
 import it.vercruysse.lemmyapi.datatypes.Tagline
 import kotlinx.coroutines.launch

 @OptIn(ExperimentalMaterial3Api::class, ExperimentalComposeUiApi::class)
 @Composable
-fun HomeScreen(
+fun HomePane(


Now that these are panes and not screens, I don't know whether its really appropriate to pass them viewmodels. I left everything as is for now.

dessalines · 2024-11-20T16:32:20Z

app/src/main/java/com/jerboa/ui/components/home/HomePane.kt

@@ -96,8 +98,10 @@ fun HomeScreen(
    postActionBarMode: PostActionBarMode,
    swipeToActionPreset: SwipeToActionPreset,
    padding: PaddingValues,
+    onPostClick: (PostView) -> Unit,


We need to highjack this action, because the list-detail view uses its own pseudo navigation.

dessalines · 2024-11-20T16:32:55Z

app/src/main/java/com/jerboa/ui/components/post/PostListings.kt

+
+            Column(
+                modifier = Modifier
+                    .background(selectedItemContainerColor(selected)),


Only change here is adding the background when its selected.

dessalines · 2024-11-20T16:33:49Z

app/src/main/java/com/jerboa/ui/components/post/PostPane.kt

+    // Some hacky code required to update the screen for tablet view
+    // Necessary because the viewmodel initializes only once.
+    if (postViewModel.id !== postOrCommentId) {
+        postViewModel.reInitializeWithNewId(postOrCommentId)
+    }


This had me scratching my head for a while. Clicking on a new post in the list didn't re-init the viewmodel, so it kept showing the first post selected.

ViewModels are bound to the lifetime of the screen (navigation target). It reuses it as long as the screen exists.

see https://developer.android.com/topic/libraries/architecture/viewmodel#jetpack-compose

dessalines · 2024-11-20T16:35:13Z

app/src/main/java/com/jerboa/ui/components/home/HomeNavScreen.kt

+                Scaffold(
+                    snackbarHost = { JerboaSnackbarHost(snackbarHostState) },
+                    content = { padding ->


It's strange to embed a scaffold within the adaptive scaffold, but its the only way to pass the snackbarhost for the error messages.

app/build.gradle.kts

MV-GH · 2024-11-20T21:34:41Z

app/src/main/java/com/jerboa/model/PostViewModel.kt

@@ -79,6 +79,11 @@ class PostViewModel(
        this.getData()
    }

+    fun reInitializeWithNewId(id: Either<PostId, CommentId>) {


I haven't fully checked it out

But I think the idea was rather that you would recreate a new postViewModel each time.

I haven't this out yet but this might not play well with the state that won't be remembered. Like sorts.

app/src/main/java/com/jerboa/ui/components/common/AccountHelpers.kt

MV-GH · 2024-11-20T21:42:51Z

app/src/main/java/com/jerboa/ui/components/common/AppBars.kt

-        val window = (LocalContext.current as Activity).window
-        val colorScheme = MaterialTheme.colorScheme
-
-        DisposableEffect(Unit) {


I see this is also gone but this was really necessary for the navigation bar to look the same as system navigation bar.

It looked quite odd. I'll check it out later to see how this looks now.

I don't see any need for these now in the jetpack compose code, maybe they were necessary once, but now with edgeToedge , it seems to handle the navbar coloring fine.

Not on older API levels

Before

After

I prefer we keep it, this was tested on Android 12, so not even that old.

…ablet

MV-GH · 2024-11-20T22:07:24Z

Ill have time this weekend for a proper review + testing

dessalines · 2024-11-20T22:08:30Z

Sweet, thx.

MV-GH · 2024-11-26T01:23:08Z

Mb I'll have time tomorrow

MV-GH · 2024-11-26T22:02:20Z

I am getting crashes

stacktrace

FATAL EXCEPTION: main
Process: com.jerboa.debug, PID: 2623
java.lang.NoSuchMethodError: No interface method removeFirst()Ljava/lang/Object; in class Ljava/util/List; or its super classes (declaration of 'java.util.List' appears in /apex/com.android.art/javalib/core-oj.jar)
	at com.jerboa.UtilsKt.getCommentParentId(Utils.kt:824)
	at com.jerboa.UtilsKt.recCreateAndGenMissingCommentData(Utils.kt:186)
	at com.jerboa.UtilsKt.buildCommentsTree(Utils.kt:166)
	at com.jerboa.ui.components.post.PostPaneKt$PostPane$14$2.invoke$lambda$36(PostPane.kt:491)
	at com.jerboa.ui.components.post.PostPaneKt$PostPane$14$2.$r8$lambda$3mSIQh7EFo9ZE2NxXXAs9Y27qzY(Unknown Source:0)
	at com.jerboa.ui.components.post.PostPaneKt$PostPane$14$2$$ExternalSyntheticLambda22.invoke(D8$$SyntheticClass:0)
	at androidx.compose.foundation.lazy.LazyListIntervalContent.<init>(LazyListIntervalContent.kt:34)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$intervalContentState$1.invoke(LazyListItemProvider.kt:49)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$intervalContentState$1.invoke(LazyListItemProvider.kt:48)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.DerivedSnapshotState.currentRecord(DerivedState.kt:200)
	at androidx.compose.runtime.DerivedSnapshotState.getValue(DerivedState.kt:272)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$itemProviderState$1.invoke(LazyListItemProvider.kt:52)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$itemProviderState$1.invoke(LazyListItemProvider.kt:51)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.DerivedSnapshotState.currentRecord(DerivedState.kt:200)
	at androidx.compose.runtime.DerivedSnapshotState.getCurrentRecord(DerivedState.kt:279)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.recordRead(SnapshotStateObserver.kt:463)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.recordRead(SnapshotStateObserver.kt:436)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$readObserver$1.invoke(SnapshotStateObserver.kt:168)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$readObserver$1.invoke(SnapshotStateObserver.kt:165)
	at androidx.compose.runtime.DerivedSnapshotState.getValue(DerivedState.kt:267)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$1.get(LazyListItemProvider.kt:61)
	at kotlin.jvm.internal.PropertyReference0.invoke(PropertyReference0.java:35)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$itemContentFactory$1$1.invoke(LazyLayout.kt:84)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$itemContentFactory$1$1.invoke(LazyLayout.kt:84)
	at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.<init>(LazyLayoutMeasureScope.kt:109)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke-0kLqBqw(LazyLayout.kt:114)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke(LazyLayout.kt:112)
	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:725)
	at androidx.compose.ui.node.InnerNodeCoordinator$LookaheadDelegateImpl.measure-BRTryo0(InnerNodeCoordinator.kt:83)
	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1802)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:111)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release$default(OwnerSnapshotObserver.kt:105)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:40)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1431)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:1368)
	at androidx.compose.foundation.layout.BoxMeasurePolicy.measure-3p2s80s(Box.kt:173)
	at androidx.compose.ui.node.InnerNodeCoordinator$LookaheadDelegateImpl.measure-BRTryo0(InnerNodeCoordinator.kt:83)
	at androidx.compose.foundation.layout.FillNode.measure-3p2s80s(Size.kt:699)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.foundation.layout.PaddingValuesModifier.measure-3p2s80s(Padding.kt:472)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1802)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:111)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release$default(OwnerSnapshotObserver.kt:105)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:40)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1431)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release(LayoutNode.kt:1204)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1198)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.doLookaheadRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:349)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:555)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.onlyRemeasureIfScheduled(MeasureAndLayoutDelegate.kt:660)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtreeInternal(MeasureAndLayoutDelegate.kt:686)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtreeInternal(MeasureAndLayoutDelegate.kt:693)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtree(MeasureAndLayoutDelegate.kt:649)
	at androidx.compose.ui.platform.AndroidComposeView.forceMeasureTheSubtree(AndroidComposeView.android.kt:1299)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1441)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:1368)
	at androidx.compose.animation.AnimatedEnterExitMeasurePolicy.measure-3p2s80s(AnimatedVisibility.kt:812)
	at androidx.compose.ui.node.InnerNodeCoordinator$LookaheadDelegateImpl.measure-BRTryo0(InnerNodeCoordinator.kt:83)
	at androidx.compose.animation.EnterExitTransitionModifierNode.measure-3p2s80s(EnterExitTransition.kt:1160)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.graphics.BlockGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:578)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.animation.AnimatedVisibilityKt$AnimatedVisibilityImpl$1$1.invoke-3p2s80s(AnimatedVisibility.kt:699)
	at androidx.compose.animation.AnimatedVisibilityKt$AnimatedVisibilityImpl$1$1.invoke(AnimatedVisibility.kt:698)
	at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:294)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.material3.adaptive.layout.AnimateBoundsNode.measure-3p2s80s(AnimateBoundsModifier.kt:116)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1802)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2441)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:111)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release$default(OwnerSnapshotObserver.kt:105)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:40)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1431)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release(LayoutNode.kt:1204)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1198)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.doLookaheadRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:349)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:555)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded$default(MeasureAndLayoutDelegate.kt:534)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:390)
	at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:1268)
	at androidx.compose.ui.node.Owner.measureAndLayout$default(Owner.kt:248)
	at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:1556)
	at android.view.View.draw(View.java:22647)
	at android.view.View.updateDisplayListIfDirty(View.java:21519)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:534)
	at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:540)
	at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:616)
	at android.view.ViewRootImpl.draw(ViewRootImpl.java:4421)
	at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4149)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3309)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2126)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8653)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
	at android.view.Choreographer.doCallbacks(Choreographer.java:845)
	at android.view.Choreographer.doFrame(Choreographer.java:780)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

dessalines · 2024-11-27T15:30:31Z

Unfortunately it'll be ~a week before I can check this one out.

dessalines added 2 commits November 20, 2024 10:16

Getting multi-pane home working.

09b507c

Adding navigation bar scaffold.

fbecf47

dessalines changed the title ~~Getting multi-pane home working.~~ Adding tablet UI for home Nov 20, 2024

dessalines marked this pull request as ready for review November 20, 2024 16:25

dessalines requested a review from MV-GH as a code owner November 20, 2024 16:25

dessalines commented Nov 20, 2024

View reviewed changes

Fixing back button.

78b4915

MV-GH reviewed Nov 20, 2024

View reviewed changes

app/build.gradle.kts Show resolved Hide resolved

MV-GH reviewed Nov 20, 2024

View reviewed changes

app/build.gradle.kts Outdated Show resolved Hide resolved

MV-GH reviewed Nov 20, 2024

View reviewed changes

app/src/main/java/com/jerboa/ui/components/common/AccountHelpers.kt Outdated Show resolved Hide resolved

MV-GH reviewed Nov 20, 2024

View reviewed changes

dessalines added 2 commits November 20, 2024 16:51

Merge remote-tracking branch 'origin/main' into post_listing_detail_t…

7492570

…ablet

Updating to stable compose bom.

e6546cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding tablet UI for home #1723

Adding tablet UI for home #1723

dessalines commented Nov 20, 2024 •

edited

Loading

dessalines Nov 20, 2024

dessalines Nov 20, 2024

dessalines Nov 20, 2024

dessalines Nov 20, 2024

dessalines Nov 20, 2024

MV-GH Nov 20, 2024 •

edited

Loading

dessalines Nov 20, 2024

MV-GH Nov 20, 2024

MV-GH Nov 20, 2024

dessalines Nov 20, 2024

MV-GH Nov 20, 2024

MV-GH Nov 26, 2024

MV-GH commented Nov 20, 2024

dessalines commented Nov 20, 2024

MV-GH commented Nov 26, 2024

MV-GH commented Nov 26, 2024

dessalines commented Nov 27, 2024

Adding tablet UI for home #1723

Are you sure you want to change the base?

Adding tablet UI for home #1723

Conversation

dessalines commented Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MV-GH Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MV-GH commented Nov 20, 2024

dessalines commented Nov 20, 2024

MV-GH commented Nov 26, 2024

MV-GH commented Nov 26, 2024

dessalines commented Nov 27, 2024

dessalines commented Nov 20, 2024 •

edited

Loading

MV-GH Nov 20, 2024 •

edited

Loading