-
Notifications
You must be signed in to change notification settings - Fork 76
update deployment procedure #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mbrousset-ledger
commented
Jan 15, 2026
- add .pre-commit-config.yaml and actionlint.yaml for local workflow enforcement
- replace npm deployment wf with reusable wf
…erfiles (part of migrating these to ledger-app-workflows)
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
| name: Get tag | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| tag: ${{ steps.get_tag.outputs.tag }} | ||
| steps: | ||
| - name: Get tag | ||
| id: get_tag | ||
| #run: echo "tag=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT | ||
| run: echo "tag=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT | ||
|
|
||
| test_tools: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
To fix the problem, add an explicit permissions block to the get_tag job (or at the workflow root) that restricts the GITHUB_TOKEN to the least privilege required. Since get_tag only reads environment variables and writes to $GITHUB_OUTPUT, it does not need any token permissions at all; we can safely set permissions: {} for that job, which disables all default permissions. This aligns with how the other jobs in the same workflow already declare explicit permissions, but tailored to this job’s needs.
Concretely, in .github/workflows/docker-image-publish.yml, under the get_tag job (below runs-on: ubuntu-latest is a clear place), insert a permissions: {} block with proper indentation. No additional imports or methods are needed; this is a pure configuration change in the workflow YAML. No existing functionality changes, because get_tag never used GITHUB_TOKEN in the first place.
-
Copy modified line R19
| @@ -16,6 +16,7 @@ | ||
| get_tag: | ||
| name: Get tag | ||
| runs-on: ubuntu-latest | ||
| permissions: {} | ||
| outputs: | ||
| tag: ${{ steps.get_tag.outputs.tag }} | ||
| steps: |