add --nfc flag to use NFC apdu media #519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrichard-ledger
force-pushed
the
support_nfc_apdu
branch
from
ae67873
to
8ff7576
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
==========================================
- Coverage 44.91% 44.81% -0.10%
==========================================
Files 120 121 +1
Lines 12067 12127 +60
Branches 966 966
==========================================
+ Hits 5420 5435 +15
- Misses 6312 6357 +45
Partials 335 335 ☔ View full report in Codecov by Sentry. |
speculos/mcu/seproxyhal.py
Outdated
| @@ -270,7 +275,10 @@ def __init__(self, | |||
| self.socket_helper.wait_until_tick_is_processed) | |||
| self.time_ticker_thread.start() | |||
|
|
|||
| self.usb = usb.USB(self.socket_helper.queue_packet, transport=transport) | |||
| usb_transport = transport if transport in ['hid', 'u2f'] else 'hid' | |||
There was a problem hiding this comment.
Suggested change
| usb_transport = transport if transport in ['hid', 'u2f'] else 'hid' | |
| usb_transport = transport if transport.lower() in ['hid', 'u2f'] else 'hid' |
There was a problem hiding this comment.
Arguably weird to check that here, when USB.__init__ already has equivalent check. Might as well replace the raise ValueError by a self.transport = Hid(self.send_xfer) there if fallbacking on HID is the expected behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.