-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --nfc flag to use NFC apdu media #519
Merged
Merged
+298
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrichard-ledger
force-pushed
the
support_nfc_apdu
branch
from
September 27, 2024 15:28
ae67873
to
8ff7576
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
=======================================
Coverage 43.85% 43.86%
=======================================
Files 122 125 +3
Lines 12358 12448 +90
Branches 993 993
=======================================
+ Hits 5420 5460 +40
- Misses 6603 6653 +50
Partials 335 335 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
lpascal-ledger
force-pushed
the
support_nfc_apdu
branch
from
November 18, 2024 13:16
5cbdab5
to
71160c9
Compare
…tance as they are exclusive
…SB transport classes
lpascal-ledger
force-pushed
the
support_nfc_apdu
branch
from
November 21, 2024 15:33
f4c5ac0
to
6518a6d
Compare
Some comments on my latest changes:
|
lpascal-ledger
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.