-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clean] Better (and faster) shutdown process #459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
previously approved these changes
Feb 23, 2024
lpascal-ledger
force-pushed
the
clean/better_shutdown
branch
from
February 26, 2024 08:02
47dd03a
to
fe058e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 45.26% 45.26% -0.01%
==========================================
Files 120 120
Lines 11928 11924 -4
Branches 957 957
==========================================
- Hits 5399 5397 -2
+ Misses 6194 6192 -2
Partials 335 335 ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
previously approved these changes
Feb 26, 2024
lpascal-ledger
force-pushed
the
clean/better_shutdown
branch
3 times, most recently
from
February 26, 2024 10:14
ff1684d
to
9db8eab
Compare
lpascal-ledger
force-pushed
the
clean/better_shutdown
branch
from
February 26, 2024 10:28
9db8eab
to
0db59bf
Compare
xchapron-ledger
previously approved these changes
Feb 26, 2024
lpascal-ledger
force-pushed
the
clean/better_shutdown
branch
from
February 26, 2024 10:29
0db59bf
to
f328126
Compare
xchapron-ledger
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.