Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update app #2

wants to merge 7 commits into from

Conversation

pscott
Copy link

@pscott pscott commented Jan 19, 2021

Some PRs got merged on the ledger-nanos-sdk, so an update was required here :)

I used ".into()" for StatusWords, but we could change that to "Reply::from(..)" if you'd like (though it's a bit more verbose imho).

@kingofpayne
Copy link
Collaborator

I think most of the changes have been integrated in master now.
Regarding .into calls for status words, it has been made optional in the SDK as it was looking to much verbose (this is why this PR has not been merged in the first place).

We may keep commits 85e437c and 0451de1 as it.
We can apply changes of 9536151 but it requires to be updated as code in master has slightly changed for this method.
Can you update the branch to resolve all conflicts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pscott @kingofpayne