CERT: Refactoring of custom CA elements #814
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
=======================================
Coverage 35.49% 35.49%
=======================================
Files 13 13
Lines 1606 1606
=======================================
Hits 570 570
Misses 1036 1036
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nroggeman-ledger
approved these changes
Oct 23, 2024
Custom CA elements are now grouped in the `CERT` module in the OS. In this context, this commit: - Remove `os_customca_verify` syscall - Rename `custom_ca_get_info` and `custom_ca_revoke` syscalls
abonnaudet-ledger
force-pushed
the
abo_CERT_module
branch
from
d8c6dea
to
9a0ce16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom CA elements are now grouped in the
CERTmodule in the OS.In this context, this commit:
os_customca_verifysyscallcustom_ca_get_infoandcustom_ca_revokesyscallsDescription
Please provide a detailed description of what was done in this PR.
(And mention any links to an issue docs)
Changes include
Breaking changes
A public syscall is removed (os_customca_verify), but it was not used by any app.