Cleaned up arguments passed to the assembler #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
clean/apa/assembler_arguments
branch
from
0752328
to
db4b888
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
=======================================
Coverage 35.76% 35.76%
=======================================
Files 13 13
Lines 1591 1591
=======================================
Hits 569 569
Misses 1022 1022
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cedelavergne-ledger
approved these changes
Oct 17, 2024
apaillier-ledger
force-pushed
the
clean/apa/assembler_arguments
branch
from
db4b888
to
316e78d
Compare
Removes need for -Wno-unused-command-line-argument
apaillier-ledger
force-pushed
the
clean/apa/assembler_arguments
branch
from
316e78d
to
639b629
Compare
6 tasks
abonnaudet-ledger
pushed a commit
that referenced
this pull request
Oct 21, 2024
Cleaned up arguments passed to the assembler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No impact on apps build (same checksum), removes the need for a flag that was added in #793
Changes include