Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action button in Home Screen #770

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to improve the action button management in Home Screen, to fill the needs of two types of action button, with black and white background.
https://www.figma.com/design/k9Q6hP0XWAw00AiT6GDb0O/02.-App-SDK?node-id=2882-13313&t=Zbn3xFRm5K3sHRL9-4
https://www.figma.com/design/k9Q6hP0XWAw00AiT6GDb0O/02.-App-SDK?node-id=2882-13345&t=Zbn3xFRm5K3sHRL9-4

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

lib_nbgl/doc/nbgl_use_case.dox Outdated Show resolved Hide resolved
lib_nbgl/doc/nbgl_use_case.dox Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_layout.c Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_layout.c Show resolved Hide resolved
@nroggeman-ledger nroggeman-ledger force-pushed the improved-action-button-in-home-page branch from 1e3558d to 4e11b35 Compare September 18, 2024 12:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.32%. Comparing base (73b6dbb) to head (ecf4521).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #770   +/-   ##
=======================================
  Coverage   60.32%   60.32%           
=======================================
  Files          13       13           
  Lines        1807     1807           
=======================================
  Hits         1090     1090           
  Misses        717      717           
Flag Coverage Δ
unittests 60.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the improved-action-button-in-home-page branch from 4e11b35 to ecf4521 Compare September 18, 2024 14:59
@nroggeman-ledger nroggeman-ledger merged commit 766b9c1 into master Sep 18, 2024
194 checks passed
@nroggeman-ledger nroggeman-ledger deleted the improved-action-button-in-home-page branch September 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants