Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too long text shortening in details #763

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix 2 issues with two long "value" fields in reviews:

  • In case of a "Skippable" review, the last line of value may be out of the area
  • In the "Details" view, the last line may be wrongly cut (at "...") if ending with a '\n'

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.89%. Comparing base (ac62f3e) to head (5544a00).

Files with missing lines Patch % Lines
lib_nbgl/src/nbgl_fonts.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   59.96%   59.89%   -0.07%     
==========================================
  Files          12       12              
  Lines        1721     1723       +2     
==========================================
  Hits         1032     1032              
- Misses        689      691       +2     
Flag Coverage Δ
unittests 59.89% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit 3cf221a into master Sep 9, 2024
197 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-too-long-text-shortening-in-details branch September 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants