Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the wording on the warning screen for blind signing #747

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

To be in line with the new Figma designs.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.20%. Comparing base (b48130d) to head (c6ff915).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #747   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files          12       12           
  Lines        1729     1729           
=======================================
  Hits         1041     1041           
  Misses        688      688           
Flag Coverage Δ
unittests 60.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vforgeoux-ledger vforgeoux-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording looks good to me.

@apaillier-ledger apaillier-ledger merged commit fddeb90 into master Aug 13, 2024
196 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/blind_signing_warning branch August 13, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants