You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For transactions with SendMaxAmount: transaction amount was substituted with default amount that was calculated without network estimation.
To solve this tx amount calculation moved out form the buildTransaction function, to getFee. Because this is the only place where we expect to have tx with hardcoded/default gas amounts.
And this change restores Single responsibility for buildTransaction.
❓ Context
JIRA or GitHub link:
🧐 Checklist for the PR Reviewers
The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)
⚠️ main bundle size significantly increased: 1.8mb -> 2mb. Please check if this is expected. ⚠️ renderer bundle size significantly increased: 36.7mb -> 38.1mb. Please check if this is expected. ⚠️@opentelemetry/semantic-conventions library is now duplicated in main (regression) ⚠️@opentelemetry/core library is now duplicated in main (regression) ⚠️ms library is now duplicated in main (regression) ⚠️debug library is now duplicated in main (regression) ⚠️ajv library is now duplicated in main (regression) ⚠️@celo/base/lib/address library is now duplicated in renderer (regression) ⚠️@celo/base/lib/signatureUtils library is now duplicated in renderer (regression) ⚠️@celo/utils/lib/address library is now duplicated in renderer (regression) ⚠️@celo/utils/lib/solidity library is now duplicated in renderer (regression) ⚠️@celo/utils/lib/signatureUtils library is now duplicated in renderer (regression)
⚠️ main.ios.jsbundle bundle size significantly increased: 60.2mb -> 61.9mb. Please check if this is expected. ⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.9mb. Please check if this is expected.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
live-github-bot
bot
added
desktop
✅ Checklist
npx changesetwas attached.📝 Description
For transactions with
SendMaxAmount: transaction amount was substituted with default amount that was calculated without network estimation.To solve this tx amount calculation moved out form the buildTransaction function, to getFee. Because this is the only place where we expect to have tx with hardcoded/default gas amounts.
And this change restores Single responsibility for buildTransaction.
❓ Context
🧐 Checklist for the PR Reviewers