Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aptos): bridge integration tests #8721

Open
wants to merge 23 commits into
base: feat/integrate-aptos
Choose a base branch
from

Conversation

semeano
Copy link

@semeano semeano commented Dec 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Bridge integration test for Aptos.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Dec 20, 2024 4:30pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 4:30pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 4:30pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 4:30pm

Copy link
Member

@jccguimaraes jccguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments.

@semeano semeano force-pushed the test/aptos_bridge-integration-tests branch from c39dd52 to 9db3dfa Compare December 19, 2024 17:14
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 19, 2024

Desktop Bundle Checks

Comparing 48c18bc against 370612f.

⚠️ main bundle size significantly increased: 1.8mb -> 2mb. Please check if this is expected.
⚠️ renderer bundle size significantly increased: 36.7mb -> 38.1mb. Please check if this is expected.
⚠️ @opentelemetry/semantic-conventions library is now duplicated in main (regression)
⚠️ @opentelemetry/core library is now duplicated in main (regression)
⚠️ ms library is now duplicated in main (regression)
⚠️ debug library is now duplicated in main (regression)
⚠️ ajv library is now duplicated in main (regression)
⚠️ @celo/base/lib/address library is now duplicated in renderer (regression)
⚠️ @celo/base/lib/signatureUtils library is now duplicated in renderer (regression)
⚠️ @celo/utils/lib/address library is now duplicated in renderer (regression)
⚠️ @celo/utils/lib/solidity library is now duplicated in renderer (regression)
⚠️ @celo/utils/lib/signatureUtils library is now duplicated in renderer (regression)

Mobile Bundle Checks

Comparing 48c18bc against 370612f.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.2mb -> 61.9mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.9mb. Please check if this is expected.

@semeano semeano requested a review from a team as a code owner December 20, 2024 10:51
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants