Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› (lld) notification center and action cards #8452

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Nov 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Braze Action cards and notifs center text issue

πŸ“ Description

Fix issue with actions card layout and notif layout introduced with a previous PR.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner November 22, 2024 17:54
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Nov 22, 2024 5:54pm
native-ui-storybook ⬜️ Ignored (Inspect) Nov 22, 2024 5:54pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 22, 2024 5:54pm
web-tools ⬜️ Ignored (Inspect) Nov 22, 2024 5:54pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant