-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 [NOT A REAL RELEASE - TEST ONLY, by @angusbayley] Release 2024-11-22 #8451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛(llm) fix landingpage load from notif
fix: playwright, and wrong import and export
* feat: alpaca allow transaction crafting for staking Signed-off-by: Stéphane Prohaszka <[email protected]> * chore: changeset Signed-off-by: Stéphane Prohaszka <[email protected]> --------- Signed-off-by: Stéphane Prohaszka <[email protected]>
feat: ✨ Landing Page Sticky CTA Content Card + ✅ Add Integration test
chore: add missing watch:es for common
…n drawer for consistency with swap (#8402) * fix: sell completed tx styles * chore: add changeset * chore: minor changeset
* feat: uni history * fix: tests * chore: lint * fix: Uniswap history for tokens
* DISABLE_TRANSACTION_BROADCAST logic moved from github workflow to test suites
ci: remove changeset-enforce
<!-- Thank you for your contribution! 👍 Please make sure to read CONTRIBUTING.md if you have not already. Pull Requests that do not comply with the rules will be arbitrarily closed. --> ### ✅ Checklist <!-- Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready. --> - [x] `npx changeset` was attached. - [ ] **Covered by automatic tests.** <!-- if not, please explain. (Feature must be tested / Bug fix must bring non-regression) --> - [ ] **Impact of the changes:** <!-- Please take some time to list the impact & what specific areas Quality Assurance (QA) should focus on --> - ... ### 📝 Description Add analytics related to the Swap application <!-- | Before | After | | ------------- | ------------- | | | | --> ### ❓ Context - [fix(LIVE-14877): user clicks on History tab](https://ledgerhq.atlassian.net/browse/LIVE-14877) - [fix(LIVE-14876): user clicks on slow/medium/fast to chose network fees](https://ledgerhq.atlassian.net/browse/LIVE-14876) - [fix(LIVE-14875): user close "X"](https://ledgerhq.atlassian.net/browse/LIVE-14875) --- ### 🧐 Checklist for the PR Reviewers <!-- Please do not edit this if you are the PR author --> - **The code aligns with the requirements** described in the linked JIRA or GitHub issue. - **The PR description clearly documents the changes** made and explains any technical trade-offs or design decisions. - **There are no undocumented trade-offs**, technical debt, or maintainability issues. - **The PR has been tested** thoroughly, and any potential edge cases have been considered and handled. - **Any new dependencies** have been justified and documented. - **Performance** considerations have been taken into account. (changes have been profiled or benchmarked if necessary)
LIVE-13682 Feat/coin modularization vechain
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
mobile
Has changes in LLM
common
Has changes in live-common
ui
Has changes in the design system library
ledgerjs
Has changes in the ledgerjs open source libs
automation
CI/CD stuff
labels
Nov 22, 2024
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release is on the way 🚀!
This pull request is the next release in the Ledger Live JS ecosystem.
Checklist
To be ready to be merged, we must comply with all theses checks:
/!\ If this release includes a new version of Ledger Live Desktop
Once all these checks are validated, the pull request can be merged using the correct workflow.