Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: casper support on memo tag send flow #8419

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: casper support on memo tag send flow #8419

merged 1 commit into from
Nov 25, 2024

Conversation

themooneer
Copy link
Contributor

@themooneer themooneer commented Nov 20, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This work consist to support Casper send flow within the new Memo/Tag flow.

  • add MemoTag (TransferId) field in the first step of the send flow (keeping the same label/wording)
  • on feature flag off, the legacy input will be shown on the second step.

NOTE before the review (please read this) 🚨

  • business logic in the apps/ledger-live-desktop/src/renderer/families/casper/MemoField.tsx component is a copy for apps/ledger-live-desktop/src/renderer/families/casper/TransferId.tsx component with just an input change in order to secure the legacy with the feature flag. -> it will be deleted on the deletion of lldMemoTag
Feature flag 📴 Preview
casper_ff_off.mov
Feature flag 🔛 Preview
casper_ff_on.mov

❓ Context

  • JIRA or GitHub link:

https://ledgerhq.atlassian.net/browse/LIVE-14921

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@themooneer themooneer requested review from a team as code owners November 20, 2024 11:58
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 4:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 4:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 4:02pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 4:02pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Nov 20, 2024
@themooneer themooneer force-pushed the fix/casper_memo_tag branch 3 times, most recently from 6485fda to 9a2ec2c Compare November 20, 2024 12:09
thesan
thesan reviewed Nov 21, 2024
View reviewed changes
apps/ledger-live-desktop/src/newArch/features/MemoTag/utils.ts Outdated
@@ -10,6 +10,7 @@ import { MEMO_TAG_COINS } from "./constants";
* @returns {string | undefined} The memo tag value if the transaction family is supported, otherwise undefined.
*/
export const getMemoTagValueByTransactionFamily = (transaction: Transaction) => {
console.log(transaction);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops ! fixed

thesan
thesan reviewed Nov 21, 2024
View reviewed changes
apps/ledger-live-desktop/src/newArch/features/MemoTag/__tests__/MemoTagField.test.tsx Outdated
@@ -5,6 +5,7 @@
import React from "react";
import { render, screen, fireEvent } from "tests/testUtils";
import MemoTagField from "../components/MemoTagField";
import { act } from "react-dom/test-utils";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@themooneer themooneer force-pushed the fix/casper_memo_tag branch 2 times, most recently from 5be5200 to c526ee7 Compare November 21, 2024 12:57
thesan
thesan previously approved these changes Nov 21, 2024
View reviewed changes
Wozacosta
Wozacosta previously approved these changes Nov 25, 2024
View reviewed changes
@themooneer themooneer dismissed stale reviews from Wozacosta and thesan via 795e21e November 25, 2024 10:35
@themooneer themooneer force-pushed the fix/casper_memo_tag branch 2 times, most recently from 795e21e to 14dc891 Compare November 25, 2024 13:35
@themooneer themooneer merged commit 24e2ef9 into develop Nov 25, 2024
41 checks passed
@themooneer themooneer deleted the fix/casper_memo_tag branch November 25, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wozacosta Wozacosta Wozacosta approved these changes

@thesan thesan thesan approved these changes

Assignees

@themooneer themooneer

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themooneer @Wozacosta @thesan