Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ethStakingModalWithFiltersEnabled analytics ab tracking #8249

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

beths-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • .... No behaviour change when using the modal
      Only Segment analytics should update with the new trait

📝 Description

ADD ethStakingModalWithFiltersEnabled user trait to allow easy ab testing and rollout of new staking modal with filters.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@beths-ledger beths-ledger requested a review from a team as a code owner October 30, 2024 11:12
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 30, 2024 11:13am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 30, 2024 11:13am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 30, 2024 11:13am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 30, 2024 11:13am
web-tools ⬜️ Ignored (Inspect) Oct 30, 2024 11:13am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant