[DNM] add changesets-enforce workflow #8244
Draft
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
2 times, most recently
from
f1fbfc5
to
ad51cc2
Compare
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
from
ad51cc2
to
6d8eade
Compare
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
from
6d8eade
to
e40ea19
Compare
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
from
e40ea19
to
e303b22
Compare
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
from
e303b22
to
06dd4fd
Compare
angusbayley
changed the title
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
5 times, most recently
from
06de82c
to
19f407e
Compare
angusbayley
force-pushed
the
support/enforce-changesets-no-patch
branch
from
19f407e
to
b7fde79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - awaiting release strategy. We need to time this with the larger process change
Adds workflow to enforce changesets version bumps at the
majororminorlevel only (patchwill cause build failure).Ticket here
This works on an entire-repo-snapshot basis, so if there are
patches in @develop and you've branched off @develop, and your commit does't create an offending changeset, your PR will still fail even though it wasn't your fault (this is currently the case for all tests and code quality checks too - I'm just being explicit). What this does mean is when we merge this all builds will go red until the changeset history is cleared on next release.Note that the workflow fails with a useful error message:
The workflow is async, and typically takes 15-20s to run:
The checkout step was optimised to only pull in what was needed for this workflow (more details). This is a practice we should roll out to the rest of the workflows.
My only concern about this is it's adding yet another workflow at a time where there are too many workflows.