This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LL-7265 - Make empty account tokens' names uppercase #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
grsoares21
approved these changes
Jan 10, 2022
ghost
changed the title
gre
suggested changes
Jan 14, 2022
| ", ", | ||
| )} | ||
| listTokenTypesForCryptoCurrency(mainAccount.currency) | ||
| .map(c => c?.toUpperCase() ?? c) |
There was a problem hiding this comment.
it can't be falsy so you can do c => c.toUpperCase()
|
Apparently this is a forgotten PR from @lambertkevin from when you switched to your personal account. Either close it, or follow the review (and update it) so we can get it merged 🙏🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
UI Polish
Context
LL-7265
Parts of the app affected / Test plan
Add an empty account for a SubAccount Compatible Chain -> check the text