Merge pull request #2486 from LedgerHQ/release/3.1.x

release/3.1.x

.detoxrc.json

@@ -24,7 +24,7 @@
       "build": "cd android && ENVFILE=.env.mock ./gradlew assembleDebug assembleAndroidTest -DtestBuildType=debug && cd ..",
       "type": "android.emulator",
       "device": {
-        "avdName": "Nexus_5X_API_29_x86"
+        "avdName": "Nexus_6_API_30"
       }
     },
     "android.staging": {
@@ -33,7 +33,16 @@
       "build": "cd android && ENVFILE=.env.mock ./gradlew assembleStagingRelease assembleAndroidTest -DtestBuildType=stagingRelease && cd ..",
       "type": "android.emulator",
       "device": {
-        "avdName": "Nexus_5X_API_29_x86"
+        "avdName": "Nexus_6_API_30"
+      }
+    },
+    "android.staging-ci": {
+      "binaryPath": "android/app/build/outputs/apk/stagingRelease/app-x86-stagingRelease.apk",
+      "testBinaryPath": "android/app/build/outputs/apk/androidTest/stagingRelease/app-stagingRelease-androidTest.apk",
+      "build": "cd android && ENVFILE=.env.mock ./gradlew assembleStagingRelease assembleAndroidTest -DtestBuildType=stagingRelease -PwithTestButler --warning-mode all && cd ..",
+      "type": "android.emulator",
+      "device": {
+        "avdName": "Nexus_6_API_30"
       }
     }
   }

.github/workflows/detox-ci.yml

@@ -0,0 +1,76 @@
+name: Detox E2E CI
+
+on:
+  pull_request:
+    branches:
+      - "*"
+  workflow_dispatch:
+    inputs:
+      prNumber:
+        description: pr number to trigger on
+        required: true
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  ios:
+    runs-on: macos-latest
+    steps:
+      - name: Checkout PR
+        uses: actions/checkout@v2
+        with:
+          ref: ${{github.event.pull_request.head.ref}}
+          repository: ${{github.event.pull_request.head.repo.full_name}}
+
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.6 # Not needed with a .ruby-version file
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+
+      - name: Install applesimutils
+        run: |
+          brew tap wix/brew
+          brew install applesimutils
+
+      - name: Setup Node
+        uses: actions/setup-node@v2
+        with:
+          node-version: 14
+          cache: 'yarn'
+
+      - name: Has hash commit deps
+        uses: ledgerhq/actions/packages/has-hash-commit-deps@main
+        id: has-hash-commit-deps
+        with:
+          workspace: ${{ github.workspace }}
+
+      - name: Install dependencies without network concurrency
+        if: ${{ steps.has-hash-commit-deps.outputs.has-hash-commit-deps == 'true' }}
+        env:
+          JOBS: max
+        run: yarn --prefer-offline --frozen-lockfile --network-timeout 100000 --network-concurrency 1
+
+      - name: Install dependencies with network concurrency
+        if: ${{ steps.has-hash-commit-deps.outputs.has-hash-commit-deps == 'false' }}
+        env:
+          JOBS: max
+        run: yarn --prefer-offline --frozen-lockfile --network-timeout 100000
+
+      - name: Rebuild detox
+        run: yarn detox clean-framework-cache && yarn detox build-framework-cache
+
+      - name: Build iOS app for Detox test run
+        env:
+          NODE_OPTIONS: "--max-old-space-size=7168"
+        run: yarn e2e:build -c ios.staging
+
+      - name: Test iOS app
+        timeout-minutes: 15
+        run: yarn e2e:test -c ios.staging --loglevel verbose --record-logs failing --record-timeline all --take-screenshots all --record-videos failing --detectOpenHandles
+      - name: Upload test artifacts
+        if: always()
+        uses: actions/upload-artifact@v2
+        with:
+          name: test-ios-artifacts
+          path: artifacts

README.md

@@ -22,14 +22,20 @@ It communicates with the [Ledger Nano X](https://www.ledger.com/pages/ledger-nan
 
 - Node LTS version
 - Yarn 1.10.1 or above
+- [Full React Native environment setup instructions here, **under "React Native CLI Quickstart" tab**](https://reactnative.dev/docs/environment-setup)
 
 ### iOS
 
 - XCode
+- Ruby 2.6.8 or above. The macOS built-in Ruby [does not work properly for installing dependencies of the iOS app](https://jeffreymorgan.io/articles/ruby-on-macos-with-rvm/), you have to install Ruby with for instance [Homebrew](https://brew.sh/) or [rvm](https://rvm.io/rvm/install) and make sure that `which ruby` points to that newly installed Ruby.
 
 ### Android
 
 - Android Studio
+- JDK 11
+- Required SDK tools: (go to Android Studio > Tools > SDK Manager > SDK Tools > check "Show Package Details" at the bottom right)
+  - Android NDK 21.4.7075529 (in case this doc is outdated, check the version specified as `ndkVersion` in `android/build.gradle`)
+  - CMake 3.10.2
 
 ## Scripts