Skip to content

Conversation

@jdabbech-ledger
Copy link
Contributor

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Documentation is up-to-date
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copilot AI review requested due to automatic review settings June 5, 2025 15:51
@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner June 5, 2025 15:51
@vercel
Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 3:51pm
doc-device-management-kit ❌ Failed (Inspect) Jun 5, 2025 3:51pm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request backmerges main and primarily updates package versions, adjusts package privacy settings, and adds new functionality for signing delegation authorizations. Key changes include:

  • Bumping version numbers and updating the changelog for the Bitcoin signer package.
  • Marking several packages (context-module, mockserver-client, and flipper-plugin-client) as private.
  • Introducing a new delegation authorization API in both the device management kit and its documentation.

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/signer/signer-btc/package.json Updated version from 1.0.0 to 1.0.1
packages/signer/signer-btc/CHANGELOG.md Changelog updated for version 1.0.1 patch changes
packages/signer/context-module/package.json Changed "private" from false to true
packages/mockserver-client/package.json Changed "private" from false to true
packages/flipper-plugin-client/package.json Changed "private" from false to true
packages/device-management-kit/src/api/device-action/model/UserInteractionRequired.ts Added SignDelegationAuthorization enum member
packages/device-management-kit/src/api/apdu/utils/ByteArrayBuilder.ts Added new TLV encoding methods for hexadecimal, buffer, and uint64 values
packages/device-management-kit/src/api/apdu/utils/ByteArrayBuilder.test.ts Added tests for the new TLV encoding functionality
apps/sample/src/components/SignerEthView/index.tsx Introduced a new device action for signing delegation authorizations
apps/docs/pages/docs/references/signers/eth.mdx Updated documentation to include the new sign delegation authorization use case
apps/docs/pages/docs/getting-started.mdx Updated dependency versions in the getting started guide
.changeset/* Removed legacy changeset files
Comments suppressed due to low confidence (3)

packages/signer/context-module/package.json:4

  • Ensure that marking the context-module package as private is intentional, as it will prevent the package from being published.
  "private": true,

packages/mockserver-client/package.json:3

  • Verify that changing the 'private' flag to true for the mockserver-client package is deliberate to avoid unintentional publication.
  "private": true,

packages/flipper-plugin-client/package.json:3

  • Confirm that setting the flipper-plugin-client package to private is as intended, which will keep it internal.
  "private": true,

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Fails
🚫

Please fix the PR branch name to match the convention, see CONTRIBUTING.md.

Wrong branch name: main

ℹ️ Regex to match: /^(release|chore\/backmerge(-.+){0,}|(feature|feat|bugfix|bug|hotfix|fix|support|chore|core|doc|refacto|refactor)\/((dsdk)-[0-9]+|no-issue|issue-[0-9]+)-.+)/i

  • Rules:
    • Must start with a type (feature, feat, bugfix, bug, hotfix, fix, support, chore, core, doc, refacto, refactor)
    • Followed by a SLASH ("/")
    • Followed by a JIRA issue number (DSDK-1234) or "no-issue" or "issue-1234" if fixing a Github issue
    • Followed by a DASH ("-")
    • Followed by a description

ℹ️ Example: feat/dsdk-1234-my-feature

🚫

Please fix the PR title to match the convention, see CONTRIBUTING.md.

Wrong PR title: Backmerge main

ℹ️ Regex to match: /^.+ \(([a-z]+\-?){1,}\) \[(DSDK-[0-9]+|NO-ISSUE|ISSUE-[0-9]+)\]: [A-Z].*/

  • Rules:
    • Must start with a word (usually an emoji)
    • Followed by a SPACE
    • Followed by a scope in parentheses and in LOWERCASE
    • Followed by a SPACE
    • Followed by a JIRA issue number or NO-ISSUE or ISSUE- in [brackets] (uppercase)
    • Followed by a colon (":") and a SPACE
    • Followed by a Capitalized message

ℹ️ Example: ✨ (scope) [DSDK-1234]: My feature

Messages
⚠️ No changeset file found. Please make sure this is intended or add a changeset file.

Generated by 🚫 dangerJS against 5292f87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants