Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš‘ (smpl) [NO-ISSUE]: Rename keyring folder into signer #462

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Oct 31, 2024

πŸ“ Description

Hotfix keyring route sample

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner October 31, 2024 15:49
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 31, 2024 3:49pm

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Messages
⚠️ No changeset file found in the PR. Please add a changeset file.

Generated by 🚫 dangerJS against a3cc020

@jdabbech-ledger jdabbech-ledger merged commit a18571a into develop Oct 31, 2024
10 of 12 checks passed
@jdabbech-ledger jdabbech-ledger deleted the hotfix/no-issue-rename-smpl branch October 31, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants